From 3b6424c1a7655ef36eaf0977b29afffb428b1cbf Mon Sep 17 00:00:00 2001
From: Alexandra Heuschling <aheuschling@dunant.informatik.rwth-aachen.de>
Date: Tue, 1 Dec 2020 16:34:40 +0100
Subject: [PATCH] add support for signed char

---
 src/OpenMesh/Core/IO/reader/OMReader.cc  | 8 ++++++++
 src/Unittests/unittests_read_write_OM.cc | 6 +++---
 2 files changed, 11 insertions(+), 3 deletions(-)

diff --git a/src/OpenMesh/Core/IO/reader/OMReader.cc b/src/OpenMesh/Core/IO/reader/OMReader.cc
index 523054d5..e1c82039 100644
--- a/src/OpenMesh/Core/IO/reader/OMReader.cc
+++ b/src/OpenMesh/Core/IO/reader/OMReader.cc
@@ -873,6 +873,10 @@ void _OMReader_::check_all_std_vector_types_aux(OMFormat::Chunk::PropertyName& _
   {
     add_generic_property_aux<std::vector<char>>(_bi);
   }
+  else if(_property_type == get_string_for_type(std::vector<signed char>()))
+  {
+    add_generic_property_aux<std::vector<signed char>>(_bi);
+  }
   else if(_property_type == get_string_for_type(std::vector<double>()))
   {
     add_generic_property_aux<std::vector<double>>(_bi);
@@ -922,6 +926,10 @@ void _OMReader_::check_all_vector_types_aux(OMFormat::Chunk::PropertyName& _prop
   {
     add_generic_property_aux<OpenMesh::VectorT<char, Dim>>(_bi);
   }
+  else if(_property_type == get_string_for_type(OpenMesh::VectorT<signed char, Dim>()))
+  {
+    add_generic_property_aux<OpenMesh::VectorT<signed char, Dim>>(_bi);
+  }
   else if(_property_type == get_string_for_type(OpenMesh::VectorT<double, Dim>()))
   {
     add_generic_property_aux<OpenMesh::VectorT<double, Dim>>(_bi);
diff --git a/src/Unittests/unittests_read_write_OM.cc b/src/Unittests/unittests_read_write_OM.cc
index fd493aae..bdd449ae 100644
--- a/src/Unittests/unittests_read_write_OM.cc
+++ b/src/Unittests/unittests_read_write_OM.cc
@@ -1467,7 +1467,7 @@ std::string get_type_string(OpenMesh::HalfedgeHandle) { return "Halfedge"; }
 std::string get_type_string(OpenMesh::VertexHandle)   { return "Vertex";   }
 
 std::string get_type_string(char)                     { return "char";            }
-std::string get_type_string(signed char)              { return "signed char";            }
+std::string get_type_string(signed char)              { return "signed char";     }
 std::string get_type_string(double)                   { return "double";          }
 std::string get_type_string(float)                    { return "float";           }
 std::string get_type_string(int)                      { return "int";             }
@@ -1568,10 +1568,10 @@ void do_property(MeshT& _mesh, PropertyAction action)
 template <typename MeshT, typename HandleT, int Dim>
 void do_all_property_types_vec(MeshT& _mesh, PropertyAction action)
 {
-  //do_property<MeshT, HandleT, OpenMesh::VectorT<signed char   , Dim>>(_mesh, action);
+  do_property<MeshT, HandleT, OpenMesh::VectorT<signed char   , Dim>>(_mesh, action);
   do_property<MeshT, HandleT, OpenMesh::VectorT<double        , Dim>>(_mesh, action);
   do_property<MeshT, HandleT, OpenMesh::VectorT<float         , Dim>>(_mesh, action);
-  //do_property<MeshT, HandleT, OpenMesh::VectorT<int           , Dim>>(_mesh, action);
+  do_property<MeshT, HandleT, OpenMesh::VectorT<int           , Dim>>(_mesh, action);
   do_property<MeshT, HandleT, OpenMesh::VectorT<short         , Dim>>(_mesh, action);
   do_property<MeshT, HandleT, OpenMesh::VectorT<unsigned char , Dim>>(_mesh, action);
   do_property<MeshT, HandleT, OpenMesh::VectorT<unsigned int  , Dim>>(_mesh, action);