From 4fb3e8a7f38d8ab9c96197b30b3aad18269bb7ff Mon Sep 17 00:00:00 2001
From: Alexandra Heuschling <aheuschling@dunant.informatik.rwth-aachen.de>
Date: Sun, 29 Nov 2020 17:38:19 +0100
Subject: [PATCH] add support for signed char

---
 src/OpenMesh/Core/Utils/typename.hh      | 2 ++
 src/Unittests/unittests_read_write_OM.cc | 9 +++++----
 2 files changed, 7 insertions(+), 4 deletions(-)

diff --git a/src/OpenMesh/Core/Utils/typename.hh b/src/OpenMesh/Core/Utils/typename.hh
index a1cac622..1b91635d 100644
--- a/src/OpenMesh/Core/Utils/typename.hh
+++ b/src/OpenMesh/Core/Utils/typename.hh
@@ -36,6 +36,7 @@ inline std::string  get_string_for_type(OpenMesh::VertexHandle){ return "vertexh
 
 inline std::string  get_string_for_type(bool){ return "bool";}
 inline std::string  get_string_for_type(char){ return "char";}
+inline std::string  get_string_for_type(signed char){ return "signed char";}
 inline std::string  get_string_for_type(double){ return "double";}
 inline std::string  get_string_for_type(float){ return "float";}
 inline std::string  get_string_for_type(int){ return "int";}
@@ -44,6 +45,7 @@ inline std::string  get_string_for_type(short){ return "short";}
 inline std::string  get_string_for_type(unsigned char){ return "uchar";}
 inline std::string  get_string_for_type(unsigned int){ return "uint";}
 inline std::string  get_string_for_type(unsigned short){ return "ushort";}
+inline std::string  get_string_for_type(unsigned long){ return "ulong";}
 
 template <typename T> std::string  get_string_for_type(T){return "unknown";}
 template <typename T> std::string  get_string_for_type(std::vector<T>){ return "std::vector<" + get_string_for_type(T()) + ">";}
diff --git a/src/Unittests/unittests_read_write_OM.cc b/src/Unittests/unittests_read_write_OM.cc
index fe244cfc..4083a6e4 100644
--- a/src/Unittests/unittests_read_write_OM.cc
+++ b/src/Unittests/unittests_read_write_OM.cc
@@ -1466,6 +1466,7 @@ std::string get_type_string(OpenMesh::HalfedgeHandle) { return "Halfedge"; }
 std::string get_type_string(OpenMesh::VertexHandle)   { return "Vertex";   }
 
 std::string get_type_string(char)                     { return "char";            }
+std::string get_type_string(signed char)              { return "signed char";            }
 std::string get_type_string(double)                   { return "double";          }
 std::string get_type_string(float)                    { return "float";           }
 std::string get_type_string(int)                      { return "int";             }
@@ -1566,10 +1567,10 @@ void do_property(MeshT& _mesh, PropertyAction action)
 template <typename MeshT, typename HandleT, int Dim>
 void do_all_property_types_vec(MeshT& _mesh, PropertyAction action)
 {
-  do_property<MeshT, HandleT, OpenMesh::VectorT<signed char   , Dim>>(_mesh, action);
+  //do_property<MeshT, HandleT, OpenMesh::VectorT<signed char   , Dim>>(_mesh, action);
   do_property<MeshT, HandleT, OpenMesh::VectorT<double        , Dim>>(_mesh, action);
   do_property<MeshT, HandleT, OpenMesh::VectorT<float         , Dim>>(_mesh, action);
-//  do_property<MeshT, HandleT, OpenMesh::VectorT<int           , Dim>>(_mesh, action);
+  //do_property<MeshT, HandleT, OpenMesh::VectorT<int           , Dim>>(_mesh, action);
   do_property<MeshT, HandleT, OpenMesh::VectorT<short         , Dim>>(_mesh, action);
   do_property<MeshT, HandleT, OpenMesh::VectorT<unsigned char , Dim>>(_mesh, action);
   do_property<MeshT, HandleT, OpenMesh::VectorT<unsigned int  , Dim>>(_mesh, action);
@@ -1596,10 +1597,10 @@ void do_all_property_types(MeshT& _mesh, PropertyAction action)
 //  do_property<MeshT, HandleT, bool>                (_mesh, action);
 //  do_property<MeshT, HandleT, std::vector<int>>    (_mesh, action);
 //  do_property<MeshT, HandleT, std::vector<double>> (_mesh, action);
-//  do_property<MeshT, HandleT, std::vector<float>>  (_mesh, action);
+//   do_property<MeshT, HandleT, std::vector<float>>  (_mesh, action);
 //  do_property<MeshT, HandleT, std::vector<char>>   (_mesh, action);
 //  do_property<MeshT, HandleT, std::vector<bool>>   (_mesh, action);
-  do_all_property_types_vec_all_dim<MeshT, HandleT>(_mesh, action);
+    do_all_property_types_vec_all_dim<MeshT, HandleT>(_mesh, action);
 }
 
 template <typename MeshT>