Merge branch 'CMAKE_3.17_fix' into 'master'

Cmake 3.17 fix

See merge request OpenMesh/OpenMesh!258

CI/ci-mac-build.sh

@@ -13,6 +13,8 @@ echo "BuildPath:  $BUILDPATH"
 echo "Path:       $PATH"
 echo "Language:   $LANGUAGE"
 
+cmake --version
+
 echo -e "${OUTPUT}"
 echo ""
 echo "======================================================================"

cmake/ACGQt.cmake

@@ -101,5 +101,10 @@ macro (acg_qt5)
     # Enable automoc
     set(CMAKE_AUTOMOC ON)
 
+    if(${CMAKE_VERSION} VERSION_GREATER_EQUAL "3.17") 
+      cmake_policy(SET CMP0100 NEW)
+    endif()
+
+
   endif (QT5_FOUND)
 endmacro ()

src/OpenMesh/Apps/Decimating/DecimaterGui/CMakeLists.txt

@@ -5,19 +5,17 @@ include_directories (
   ${CMAKE_CURRENT_SOURCE_DIR}
 )
 
-# source code directories
+set (headers
-set (directories 
+  ../DecimaterViewerWidget.hh
-  ../../QtViewer
+  ../../QtViewer/QGLViewerWidget.hh
-  ../
+  ../../QtViewer/MeshViewerWidgetT.hh
+  ../../QtViewer/MeshViewerWidget.hh
+  ../../QtViewer/MeshViewerWidgetT_impl.hh
 )
 
-# collect all header and source files
-acg_append_files (headers "*.hh" ${directories})
-list (APPEND headers "../../QtViewer/MeshViewerWidgetT_impl.hh")
-
-
 set (sources
   ../../QtViewer/QGLViewerWidget.cc
+  ../../QtViewer/MeshViewerWidget.cc
   ../DecimaterViewerWidget.cc
   ../decimaterviewer.cc
 )

src/OpenMesh/Apps/Decimating/DecimaterViewerWidget.hh

@@ -91,18 +91,18 @@ struct MyTraits : public DEFAULT_TRAITS
 };
 
 typedef TRIMESH_KERNEL<MyTraits>                     mesh_t;
-typedef MeshViewerWidgetT<mesh_t>                    MeshViewerWidget;
+typedef MeshViewerWidgetT<mesh_t>                    MeshViewerWidgetDecimaterBase;
 
 //== CLASS DEFINITION =========================================================
 
 
-class DecimaterViewerWidget : public MeshViewerWidget
+class DecimaterViewerWidget : public MeshViewerWidgetDecimaterBase
 {
   Q_OBJECT
    
 public:
   
-  typedef MeshViewerWidget inherited_t;
+  typedef MeshViewerWidgetDecimaterBase inherited_t;
 
   typedef Decimater::DecimaterT<mesh_t>                decimater_t;  
   typedef Decimater::ModQuadricT< mesh_t >::Handle        mod_quadric_t;
@@ -119,7 +119,7 @@ public:
 
   /// default constructor
   explicit DecimaterViewerWidget(QWidget* _parent=0)
-    : MeshViewerWidget(_parent),
+    : MeshViewerWidgetDecimaterBase(_parent),
       animate_(false),
       timer_(0),
       steps_(1)

src/OpenMesh/Apps/Decimating/commandlineDecimater/CMakeLists.txt

@@ -5,12 +5,7 @@ include_directories (
   ${CMAKE_CURRENT_SOURCE_DIR}
 )
 
-# collect all header and source files
+acg_add_executable (commandlineDecimater ../decimater.cc)
-set (sources
-  ../decimater.cc
-)
-
-acg_add_executable (commandlineDecimater ${sources})
 
 target_link_libraries (commandlineDecimater
   OpenMeshCore

src/OpenMesh/Apps/Dualizer/CMakeLists.txt

@@ -2,14 +2,9 @@ include (ACGCommon)
 
 include_directories (
   ../../..
-  ${CMAKE_CURRENT_SOURCE_DIR}
 )
 
-# collect all header and source files
+acg_add_executable (Dualizer dualizer.cc)
-acg_append_files (headers "*.hh" .)
-acg_append_files (sources "*.cc" .)
-
-acg_add_executable (Dualizer ${headers} ${sources})
 
 target_link_libraries (Dualizer
   OpenMeshCore

src/OpenMesh/Apps/ProgViewer/CMakeLists.txt

@@ -6,15 +6,18 @@ include_directories (
 )
 
 
-# collect all header and source files
+set( headers
-acg_append_files (headers "*.hh" .)
+  ProgViewerWidget.hh
-acg_append_files (sources "*.cc" .)
+  ../QtViewer/QGLViewerWidget.hh
+  ../QtViewer/MeshViewerWidgetT.hh
+  ../QtViewer/MeshViewerWidgetT_impl.hh
+)
 
-list (APPEND sources "../QtViewer/QGLViewerWidget.cc")
+set( sources
-
+  ProgViewerWidget.cc
-list (APPEND headers "../QtViewer/QGLViewerWidget.hh")
+  progviewer.cc  
-list (APPEND headers "../QtViewer/MeshViewerWidgetT.hh")
+  ../QtViewer/QGLViewerWidget.cc
-list (APPEND headers "../QtViewer/MeshViewerWidgetT_impl.hh")
+)
 
 if (WIN32)
   acg_add_executable( ProgViewer WIN32 ${sources} ${headers})

src/OpenMesh/Apps/ProgViewer/ProgViewerWidget.hh

@@ -63,7 +63,7 @@ using namespace OpenMesh;
 using namespace OpenMesh::Attributes;
 
 
-struct MyTraits : public OpenMesh::DefaultTraits
+struct ProgTraits : public OpenMesh::DefaultTraits
 {
   VertexAttributes  ( OpenMesh::Attributes::Normal       |
                       OpenMesh::Attributes::Status       );
@@ -74,28 +74,28 @@ struct MyTraits : public OpenMesh::DefaultTraits
 };
 
   
-typedef OpenMesh::TriMesh_ArrayKernelT<MyTraits>  MyMesh;
+typedef OpenMesh::TriMesh_ArrayKernelT<ProgTraits>  MyMesh;
-typedef MeshViewerWidgetT<MyMesh>                 MeshViewerWidget;
+typedef MeshViewerWidgetT<MyMesh>                   MeshViewerWidgetProgBase;
 
 
 //== CLASS DEFINITION =========================================================
 
 	      
 
-class ProgViewerWidget : public MeshViewerWidget
+class ProgViewerWidget : public MeshViewerWidgetProgBase
 {
   Q_OBJECT
    
 public:
 
-  typedef MeshViewerWidget Base;
+  typedef MeshViewerWidgetProgBase Base;
   typedef ProgViewerWidget This;
 
 
 public:   
   /// default constructor
   explicit ProgViewerWidget(QWidget* _parent=0)
-    : MeshViewerWidget(_parent),
+    : MeshViewerWidgetProgBase(_parent),
       n_base_vertices_(0),
       n_base_faces_(0),
       n_detail_vertices_(0),

src/OpenMesh/Apps/QtViewer/CMakeLists.txt

@@ -10,9 +10,16 @@ set (directories
   .
 )
 
-# collect all header and source files
+set (sources
-acg_append_files (headers "*.hh" ${directories})
+  MeshViewerWidget.cc
-acg_append_files (sources "*.cc" ${directories})
+  QGLViewerWidget.cc
+  meshviewer.cc
+)
+
+set (headers
+  MeshViewerWidget.hh
+  QGLViewerWidget.hh  
+)
 
 if (WIN32)
   acg_add_executable (QtViewer WIN32 ${sources} ${headers})

src/OpenMesh/Apps/QtViewer/MeshViewerWidget.hh

@@ -61,12 +61,12 @@
 using namespace OpenMesh;  
 using namespace OpenMesh::Attributes;
 
-struct MyTraits : public OpenMesh::DefaultTraits
+struct MeshViewerWidgetTraits : public OpenMesh::DefaultTraits
 {
   HalfedgeAttributes(OpenMesh::Attributes::PrevHalfedge);
 };
 
-typedef OpenMesh::TriMesh_ArrayKernelT<MyTraits>  MyMesh;
+typedef OpenMesh::TriMesh_ArrayKernelT<MeshViewerWidgetTraits>  MyMesh;
 
 
 

src/OpenMesh/Apps/QtViewer/MeshViewerWidgetT.hh

@@ -191,7 +191,7 @@ protected:
 
 
 //=============================================================================
-#if defined(OM_INCLUDE_TEMPLATES) && !defined(OPENMESHAPPS_MESHVIEWERWIDGET_CC)
+#if defined(OM_INCLUDE_TEMPLATES)
 #  define OPENMESH_MESHVIEWERWIDGET_TEMPLATES
 #  include "MeshViewerWidgetT_impl.hh"
 #endif

src/OpenMesh/Apps/QtViewer/MeshViewerWidgetT_impl.hh

@@ -39,9 +39,7 @@
  *                                                                           *
  * ========================================================================= */
 
-
+#pragma once
-
-#define OPENMESHAPPS_MESHVIEWERWIDGET_CC
 
 //== INCLUDES =================================================================
 
@@ -69,7 +67,6 @@ using namespace Qt;
 #  undef max
 #endif
 
-using namespace Qt;
 //== IMPLEMENTATION ========================================================== 
 
 

src/OpenMesh/Apps/Smoothing/CMakeLists.txt

@@ -5,11 +5,7 @@ include_directories (
   ${CMAKE_CURRENT_SOURCE_DIR}
 )
 
-# collect all header and source files
+acg_add_executable (Smoothing smooth.cc)
-acg_append_files (headers "*.hh" .)
-acg_append_files (sources "*.cc" .)
-
-acg_add_executable (Smoothing ${headers} ${sources})
 
 target_link_libraries (Smoothing
   OpenMeshCore

src/OpenMesh/Apps/Subdivider/MeshViewerWidget.hh

@@ -66,18 +66,18 @@ typedef OpenMesh::TriMesh_ArrayKernelT<Traits>         Mesh;
 
 	      
 
-class MeshViewerWidget : public MeshViewerWidgetT<Mesh>
+class MeshViewerWidgetSubdivider : public MeshViewerWidgetT<Mesh>
 {
 public:
    typedef MeshViewerWidgetT<Mesh> Base;
    
   /// default constructor
-  explicit MeshViewerWidget(QWidget* _parent=0)
+  explicit MeshViewerWidgetSubdivider(QWidget* _parent=0)
     : Base(_parent)
   {}
 
   /// destructor
-  ~MeshViewerWidget() {}
+  ~MeshViewerWidgetSubdivider() {}
 
   /// open mesh
   inline bool open_mesh(const char* _filename, OpenMesh::IO::Options _opt) override

src/OpenMesh/Apps/Subdivider/SubdivideWidget.cc

@@ -98,7 +98,7 @@ SubdivideWidget(QWidget* _parent, const char* _name)
   // sel_topo_type will be set when adding the radio button.;
 
   // examiner widget
-  viewer_widget_ = new MeshViewerWidget();
+  viewer_widget_ = new MeshViewerWidgetSubdivider();
 
   vbox->addWidget(viewer_widget_);
 

src/OpenMesh/Apps/Subdivider/SubdivideWidget.hh

@@ -116,7 +116,7 @@ private slots:
 private:
 
   // widgets
-  MeshViewerWidget* viewer_widget_;
+  MeshViewerWidgetSubdivider* viewer_widget_;
 
   QTimer *timer_;
    

src/OpenMesh/Apps/Subdivider/SubdividerGui/CMakeLists.txt

@@ -5,18 +5,14 @@ include_directories (
   ${CMAKE_CURRENT_SOURCE_DIR}
 )
 
-# source code directories
+set (headers
-set (directories 
+  ../MeshViewerWidget.hh
-  ../../QtViewer
+  ../SubdivideWidget.hh
-  ../
+  ../../QtViewer/QGLViewerWidget.hh
+  ../../QtViewer/MeshViewerWidgetT.hh
+  ../../QtViewer/MeshViewerWidgetT_impl.hh
 )
 
-# collect all header and source files
-acg_append_files (headers "*.hh" ${directories})
-
-list (APPEND headers "../../QtViewer/MeshViewerWidgetT_impl.hh")
-
-
 set (sources
   ../../QtViewer/QGLViewerWidget.cc
   ../SubdivideWidget.cc

src/OpenMesh/Apps/Subdivider/commandlineAdaptiveSubdivider/CMakeLists.txt

@@ -5,12 +5,7 @@ include_directories (
   ${CMAKE_CURRENT_SOURCE_DIR}
 )
 
-# collect all header and source files
+acg_add_executable (commandlineAdaptiveSubdivider ../adaptive_subdivider.cc)
-set (sources
-  ../adaptive_subdivider.cc
-)
-
-acg_add_executable (commandlineAdaptiveSubdivider ${sources})
 
 target_link_libraries (commandlineAdaptiveSubdivider
   OpenMeshCore

src/OpenMesh/Apps/Subdivider/commandlineSubdivider/CMakeLists.txt

@@ -5,12 +5,7 @@ include_directories (
   ${CMAKE_CURRENT_SOURCE_DIR}
 )
 
-# collect all header and source files
+acg_add_executable (commandlineSubdivider ../subdivider.cc)
-set (sources
-  ../subdivider.cc
-)
-
-acg_add_executable (commandlineSubdivider ${sources})
 
 target_link_libraries (commandlineSubdivider
   OpenMeshCore

src/OpenMesh/Apps/VDProgMesh/Analyzer/CMakeLists.txt

@@ -5,12 +5,7 @@ include_directories (
   ${CMAKE_CURRENT_SOURCE_DIR}
 )
 
-# collect all header and source files
+acg_add_executable (Analyzer vdpmanalyzer.cc)
-set (sources
-  ./vdpmanalyzer.cc
-)
-
-acg_add_executable (Analyzer ${sources})
 
 target_link_libraries (Analyzer
   OpenMeshCore

src/OpenMesh/Apps/VDProgMesh/Synthesizer/CMakeLists.txt

@@ -5,15 +5,16 @@ include_directories (
   ${CMAKE_CURRENT_SOURCE_DIR}
 )
 
-# collect all header and source files
+set (headers
-acg_append_files (headers "*.hh" .)
+  VDPMSynthesizerViewerWidget.hh
-acg_append_files (sources "*.cc" .)
+)
 
-list (APPEND sources "../../QtViewer/QGLViewerWidget.cc")
+set (sources
+  ../../QtViewer/QGLViewerWidget.cc
+  vdpmsynthesizer.cc
+  VDPMSynthesizerViewerWidget.cc
+)
 
-list (APPEND headers "../../QtViewer/QGLViewerWidget.hh")
-list (APPEND headers "../../QtViewer/MeshViewerWidgetT.hh")
-list (APPEND headers "../../QtViewer/MeshViewerWidgetT_impl.hh")
 
 if (WIN32)
   acg_add_executable (Synthesizer WIN32 ${sources} ${headers})

src/OpenMesh/Apps/VDProgMesh/mkbalancedpm/CMakeLists.txt

@@ -5,12 +5,7 @@ include_directories (
   ${CMAKE_CURRENT_SOURCE_DIR}
 )
 
-# collect all header and source files
+acg_add_executable (mkbalancedpm mkbalancedpm.cc)
-set (sources
-  ./mkbalancedpm.cc
-)
-
-acg_add_executable (mkbalancedpm ${sources})
 
 target_link_libraries (mkbalancedpm
   OpenMeshCore

src/OpenMesh/Apps/mconvert/CMakeLists.txt

@@ -2,14 +2,9 @@ include (ACGCommon)
 
 include_directories (
   ../../..
-  ${CMAKE_CURRENT_SOURCE_DIR}
 )
 
-# collect all header and source files
+acg_add_executable (mconvert mconvert.cc)
-acg_append_files (headers "*.hh" .)
-acg_append_files (sources "*.cc" .)
-
-acg_add_executable (mconvert ${headers} ${sources})
 
 target_link_libraries (mconvert
   OpenMeshCore