Pixyco-XYZ/openmesh
5
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

range check for vertex colors and normals in OBJ loader

Browse Source
This commit is contained in:
Max Limper
2016-10-01 19:43:46 +02:00
parent 8b7be54eb6
commit c577810d47
1 changed files with 15 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
src/OpenMesh/Core/IO/reader/OBJReader.cc
View File

@@ -597,8 +597,14 @@ read(std::istream& _in, BaseImporter& _bi, Options& _opt)
// Obj counts from 1 and not zero .. array counts from zero therefore -1 // Obj counts from 1 and not zero .. array counts from zero therefore -1
vhandles.push_back(VertexHandle(value-1)); vhandles.push_back(VertexHandle(value-1));
faceVertices.push_back(VertexHandle(value-1)); faceVertices.push_back(VertexHandle(value-1));
if (fileOptions.vertex_has_color() ) if (fileOptions.vertex_has_color()) {
_bi.set_color(vhandles.back(), colors[value-1]); if ((unsigned int)(value - 1) < colors.size()) {
_bi.set_color(vhandles.back(), colors[value - 1]);
}
else {
omerr() << "Error setting vertex color" << std::endl;
}
}
break; break;
case 1: // texture coord case 1: // texture coord
@@ -648,9 +654,13 @@ read(std::istream& _in, BaseImporter& _bi, Options& _opt)
// Obj counts from 1 and not zero .. array counts from zero therefore -1 // Obj counts from 1 and not zero .. array counts from zero therefore -1
if (fileOptions.vertex_has_normal() ) { if (fileOptions.vertex_has_normal() ) {
assert(!vhandles.empty()); assert(!vhandles.empty());
assert((unsigned int)(value-1) < normals.size()); if ((unsigned int)(value - 1) < normals.size()) {
_bi.set_normal(vhandles.back(), normals[value-1]); _bi.set_normal(vhandles.back(), normals[value - 1]);
}
else {
omerr() << "Error setting vertex normal" << std::endl;
}
} }
break; break;
} }