Pixyco-XYZ/openmesh
5
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

use std::find_if instead of raw loop to follow style guides

Browse Source
This commit is contained in:
Alexandra Heuschling
2021-01-17 15:30:47 +01:00
parent 0d9a2bcf3c
commit f46f4b2348
1 changed files with 23 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
src/OpenMesh/Core/Utils/PropertyCreator.hh
View File

@@ -181,12 +181,29 @@ public:
template <typename HandleT> template <typename HandleT>
void create_property(BaseKernel& _mesh, const std::string& _type_name, const std::string& _property_name) void create_property(BaseKernel& _mesh, const std::string& _type_name, const std::string& _property_name)
{ {
for (const auto& pc : property_creators_)
if (pc->can_you_create(_type_name)) auto can_create = [_type_name](OpenMesh::PropertyCreator* pc){
{ return pc->can_you_create(_type_name);
pc->create_property<HandleT>(_mesh, _property_name); };
return;
} std::vector<OpenMesh::PropertyCreator*>::iterator pc_iter = std::find_if(property_creators_.begin(),
property_creators_.end(), can_create);
if (pc_iter != property_creators_.end())
{
const auto& pc = *pc_iter;
pc->create_property<HandleT>(_mesh, _property_name);
return;
}
//----------------------------------------------------
// for (const auto& pc : property_creators_)
// if (pc->can_you_create(_type_name))
// {
// pc->create_property<HandleT>(_mesh, _property_name);
// return;
// }
//------------------------------------------------------
omerr() << "No property creator registered that can create a property of type " << _type_name << std::endl; omerr() << "No property creator registered that can create a property of type " << _type_name << std::endl;
omerr() << "You need to register your custom type using OM_REGISTER_PROPERTY_TYPE(ClassName) and declare the struct binary<ClassName>.\ omerr() << "You need to register your custom type using OM_REGISTER_PROPERTY_TYPE(ClassName) and declare the struct binary<ClassName>.\
See documentation for more details." << std::endl; See documentation for more details." << std::endl;