Pixyco-XYZ/openmesh
5
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
1,779 Commits 1 Branch 0 Tags
1cb02d946f18763e8e4c3aad6a0a6f5fa594b724
Commit Graph

187 Commits

Author SHA1 Message Date
Jan Möbius
9c91f3c987 Updated changelog 2016-04-14 15:13:49 +02:00
Jan Möbius
04a01c9e99 Merge branch 'fix-nonmanifold-no-collect' into 'master' 
Not collecting failed faces but directly processing them

**Problem description:**

I encountered severe problems in my application because OpenMesh does not load attributes, such as face texture index, for failed faces (non-manifold geometry).
Instead of directly handling them, the Importer class defers the handling of failed faces to a post process - but at that point, the attribute information is not available any more, since it is read and applied in the reader, which only deals with the non-failed faces.


**Solution:**

My simple solution was to remove the list of failed faces and instead directly handle failed faces inside the "add_face" function of the Importer class.


**Discussion:**

I didn't see any drawback, compared to the previous code. It would be interesting to know why the list of failed faces was maintained - was this legacy code, or was there some idea to extend this concept, which was just  never realized? The only functional point that has changed is that I removed the code that adds degenerate faces to the mesh (line 129), since, in my opinion, this makes things just more complicated for some applications, and the benefit of being able to import degenerate faces seems marginal. But that's a design decision, it will be very easy to encapsulate the code that adds a separate face (line 140) into a separate function and use it also for degenerate faces.

It would be great to receive your feedback on this issue, and to know if it is possible to include this change (or something similar).

See merge request !51
 2016-04-14 10:56:45 +02:00
Jan Möbius
4918d2f353 Updated changelog 2016-04-14 10:36:10 +02:00
Jan Möbius
697a205389 Added check for property iterators 2016-04-07 15:51:22 +02:00
Jan Möbius
6a045b5c5e Obj writer: Fix OBJ writer bug file extension removal (Thanks to Katharina Breininger for the patch) 
(cherry picked from commit 4cfe75788a5374978555322c596ecdea9909516a)
 2016-04-05 15:44:34 +02:00
Jan Möbius
afc5101cc3 Decimater: Added missing preprocess collapse call in size_t DecimaterT<Mesh>::decimate(size_t _n_collapses) (Thanks to Andrej Ivanis for the hint) 
(cherry picked from commit 0dee5a6199d278ff2fb4299cf2cef67ba16ded6e)
 2016-04-05 15:04:09 +02:00
Jan Möbius
2592f8322a Updated Changelog 2016-03-24 13:10:28 +01:00
Jan Möbius
7fffd773c8 Correctly merge Docs for 5.2 2016-03-23 13:46:45 +01:00
Jan Möbius
434a0ed1c6 Merge branch 'obj_mat_file' into 'master' 
Fix OBJ material files and face color (Thanks to Sven-Kristofer Pilz for the patch)

closes #20 

See merge request !50
 2016-03-23 13:45:56 +01:00
Jan Möbius
57c0ec08df Updated 5.2 Docu 2016-03-23 13:42:06 +01:00
Jan Möbius
30d88d0694 Updated 5.2 changelog 
(cherry picked from commit 732bb63748e5a4a6622d3a0826815e393ae081c2)
 2016-03-23 13:09:10 +01:00
Jan Möbius
1518f073b0 Updated 5.2 changelog 
(cherry picked from commit 0093646b3692474d91c15c66d833a9280faa70f8)
 2016-02-12 12:02:05 +01:00
Jan Möbius
d43d7d2148 Updated changelog of 6.0 branch 2016-02-04 10:00:15 +01:00
Jan Möbius
74bf0672c6 Updated changelog for 5.2 
(cherry picked from commit 81e091decf29955afb8e118c496fb82e8f93989c)
 2016-02-04 09:55:56 +01:00
Jan Möbius
011fdc9700 Missing changelog entry 
(cherry picked from commit 53fca645a14b71a856654f26f6913faa0482b3eb)
 2015-12-17 09:53:55 +01:00
Jan Möbius
b18551f46d Prepare OpenMesh-5.1 for release 
(cherry picked from commit 1e8f0db6fa239f5221bd3d0d95c74a69aeb2a442)
 2015-12-17 09:52:24 +01:00
Jan Möbius
451c8f827d Updated changelog in 6.0 2015-12-15 16:11:51 +01:00
Jan Möbius
1ece1c441a Updated changelog in 5.1 
(cherry picked from commit 55d0874818ec67e4624443e9b850a95bc49db0e1)
 2015-12-15 16:09:31 +01:00
Jan Möbius
b5c22dfc7e Reduced number of includes 2015-11-30 12:29:19 +01:00
Jan Möbius
b1bbd9975f Updated changelog for 5.1 2015-11-26 13:23:36 +01:00
Jan Möbius
4b3183f57e Updated changelog for 6.0 2015-11-26 13:21:07 +01:00
Jan Möbius
df09a1816f Updated 5.1 Changelog 2015-11-26 13:17:54 +01:00
Jan Möbius
daa256e382 Updated changelog for 6.0 2015-11-23 18:24:18 +01:00
Jan Möbius
1af3b6f58a Updated changelog for 5.1 
(cherry picked from commit cb045d61528d9fe86df34ad7f6813d559b2cf73a)
 2015-11-23 18:20:54 +01:00
Jan Möbius
4cc3063091 Fixed bug preventing from building changelog 
closes #11
 2015-11-23 18:15:57 +01:00
Jan Möbius
1ab0709c9c Added changelog entries for 5.1 and 6.0 2015-11-18 14:05:14 +01:00
Jan Möbius
a8791d1116 Updated changelog for 5.0 release 2015-11-18 13:06:20 +01:00
Jan Möbius
4b322f792c Switched Release version to 5.0 and updated changelog 2015-11-11 09:13:10 +01:00
Jan Möbius
f7ac0d937f Updated changelog 2015-10-27 10:49:46 +01:00
Jan Möbius
1f8cfdeb27 Updated changelog 2015-10-01 16:46:25 +02:00
Jan Möbius
e3e7b4e166 Updated changelog 2015-09-30 08:06:56 +02:00
Jan Möbius
3591755b48 Updated changelog 
git-svn-id: http://www.openmesh.org/svnrepo/OpenMesh/trunk@1334 fdac6126-5c0c-442c-9429-916003d36597
 2015-08-28 11:39:26 +00:00
Jan Möbius
118ec2f102 Updated changelog 
git-svn-id: http://www.openmesh.org/svnrepo/OpenMesh/trunk@1324 fdac6126-5c0c-442c-9429-916003d36597
 2015-07-30 13:10:57 +00:00
Jan Möbius
68fe500f18 Moved main version to 4.2 
git-svn-id: http://www.openmesh.org/svnrepo/OpenMesh/trunk@1322 fdac6126-5c0c-442c-9429-916003d36597
 2015-07-27 07:05:50 +00:00
Jan Möbius
be465673e6 Fixed bad enum 
git-svn-id: http://www.openmesh.org/svnrepo/OpenMesh/trunk@1318 fdac6126-5c0c-442c-9429-916003d36597
 2015-07-26 20:22:28 +00:00
Jan Möbius
2d4bc6203f Updated changelog for 4.1 release 
git-svn-id: http://www.openmesh.org/svnrepo/OpenMesh/trunk@1317 fdac6126-5c0c-442c-9429-916003d36597
 2015-07-25 19:35:02 +00:00
Jan Möbius
fad45b7fd6 Updated files to version 4.1 
git-svn-id: http://www.openmesh.org/svnrepo/OpenMesh/trunk@1313 fdac6126-5c0c-442c-9429-916003d36597
 2015-07-13 13:05:22 +00:00
Jan Möbius
34958446bb Updated changelog to release state. refs #2513 
git-svn-id: http://www.openmesh.org/svnrepo/OpenMesh/trunk@1309 fdac6126-5c0c-442c-9429-916003d36597
 2015-07-08 10:22:26 +00:00
Jan Möbius
aab84e5e89 First steps to prepare 4.0 (4.0 due to relicense) 
refs #2513




git-svn-id: http://www.openmesh.org/svnrepo/OpenMesh/trunk@1304 fdac6126-5c0c-442c-9429-916003d36597
 2015-07-03 09:23:48 +00:00
Jan Möbius
9267b4a423 Updated changelog 
git-svn-id: http://www.openmesh.org/svnrepo/OpenMesh/trunk@1286 fdac6126-5c0c-442c-9429-916003d36597
 2015-06-16 09:19:02 +00:00
Jan Möbius
b15a392b9c Updated changelog 
git-svn-id: http://www.openmesh.org/svnrepo/OpenMesh/trunk@1266 fdac6126-5c0c-442c-9429-916003d36597
 2015-05-12 11:05:46 +00:00
Jan Möbius
28df7fd995 Updated changelog 
git-svn-id: http://www.openmesh.org/svnrepo/OpenMesh/trunk@1256 fdac6126-5c0c-442c-9429-916003d36597
 2015-04-28 11:41:59 +00:00
Jan Möbius
01430db4d0 Updated changelog 
git-svn-id: http://www.openmesh.org/svnrepo/OpenMesh/trunk@1250 fdac6126-5c0c-442c-9429-916003d36597
 2015-04-14 10:36:56 +00:00
Jan Möbius
823b0486d5 Updated changelog 
git-svn-id: http://www.openmesh.org/svnrepo/OpenMesh/trunk@1248 fdac6126-5c0c-442c-9429-916003d36597
 2015-03-20 12:06:52 +00:00
Jan Möbius
b7c2307919 Updated changelog 
git-svn-id: http://www.openmesh.org/svnrepo/OpenMesh/trunk@1245 fdac6126-5c0c-442c-9429-916003d36597
 2015-03-11 13:47:17 +00:00
Jan Möbius
bf21ed8ad0 Updated changelog 
git-svn-id: http://www.openmesh.org/svnrepo/OpenMesh/trunk@1235 fdac6126-5c0c-442c-9429-916003d36597
 2015-03-05 09:11:24 +00:00
Jan Möbius
c7a41edafd Updated changelog 
git-svn-id: http://www.openmesh.org/svnrepo/OpenMesh/trunk@1229 fdac6126-5c0c-442c-9429-916003d36597
 2015-02-24 11:17:49 +00:00
Jan Möbius
f9d04d793a Updated changelog 
git-svn-id: http://www.openmesh.org/svnrepo/OpenMesh/trunk@1223 fdac6126-5c0c-442c-9429-916003d36597
 2015-02-18 08:26:17 +00:00
Jan Möbius
ec108e8115 Updated changelog 
git-svn-id: http://www.openmesh.org/svnrepo/OpenMesh/trunk@1221 fdac6126-5c0c-442c-9429-916003d36597
 2015-02-10 14:42:44 +00:00
Jan Möbius
af7d0ad162 Updated changelog 
git-svn-id: http://www.openmesh.org/svnrepo/OpenMesh/trunk@1218 fdac6126-5c0c-442c-9429-916003d36597
 2015-02-06 08:35:29 +00:00