Pixyco-XYZ/openmesh
5
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

obj exporter: fail if vertex color export was requested

Browse Source
This commit is contained in:
Jan Möbius
2018-01-26 13:29:22 +01:00
parent 7856a4371b
commit 0e3491ed88
2 changed files with 15 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
Doc/changelog.docu
View File

@@ -53,6 +53,7 @@
<li>ImporterT: Modified the add_face function of importerT to always return a valid FaceHandle</li> <li>ImporterT: Modified the add_face function of importerT to always return a valid FaceHandle</li>
<li>ImporterT: Return a valid FaceHandle when adding non-manifold faces.</li> <li>ImporterT: Return a valid FaceHandle when adding non-manifold faces.</li>
<li>BaseExporter: Added accessor functions for HalfEdgeHandles and faceTexCoords to base exporter and exporter template.</li> <li>BaseExporter: Added accessor functions for HalfEdgeHandles and faceTexCoords to base exporter and exporter template.</li>
<li>OBJ Writer: Fail if vertex color export was requested (Thanks to Manuel Massing)</li>
<li>OBJ Writer: Added functionality to store FaceTexCoords to objwriter</li> <li>OBJ Writer: Added functionality to store FaceTexCoords to objwriter</li>
<li>OBJ Writer: Applied fix for bad or missing vertex tex coords (Thanks to Gero Müller for the patch)</li>> <li>OBJ Writer: Applied fix for bad or missing vertex tex coords (Thanks to Gero Müller for the patch)</li>>
<li>OBJ Loader: range check for vertex colors and normals in OBJ loader</li> <li>OBJ Loader: range check for vertex colors and normals in OBJ loader</li>

16
src/OpenMesh/Core/IO/writer/OBJWriter.cc
View File

@@ -224,12 +224,22 @@ write(std::ostream& _out, BaseExporter& _be, Options _opt, std::streamsize _prec
if (!check( _be, _opt)) if (!check( _be, _opt))
return false; return false;
// No binary mode for OBJ
if ( _opt.check(Options::Binary) ) {
omout() << "[OBJWriter] : Warning, Binary mode requested for OBJ Writer (No support for Binary mode), falling back to standard." << std::endl;
}
// check writer features // check for unsupported writer features
if ( _opt.check(Options::Binary) || // not supported by format if (_opt.check(Options::FaceNormal) ) {
_opt.check(Options::FaceNormal)) omerr() << "[OBJWriter] : FaceNormal not supported by OBJ Writer" << std::endl;
return false; return false;
}
// check for unsupported writer features
if (_opt.check(Options::VertexColor) ) {
omerr() << "[OBJWriter] : VertexColor not supported by OBJ Writer" << std::endl;
return false;
}
//create material file if needed //create material file if needed
if ( _opt.check(Options::FaceColor) ){ if ( _opt.check(Options::FaceColor) ){