Pixyco-XYZ/openmesh
5
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

add_vertex and new_vertex parameters changed to by value

Browse Source
This commit is contained in:
Jan Möbius
2024-02-22 14:54:20 +01:00
parent fc4545e4fa
commit 49aeab8d3a
4 changed files with 105 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
src/OpenMesh/Core/Mesh/PolyMeshT.hh
View File

@@ -206,11 +206,8 @@ public:
*
* \sa new_vertex(), new_vertex_dirty()
*
* \attention Be careful to not use a reference to a point in the mesh itself here.
* as a resize of the underlying vector might invalidate this reference
* and cause a segfault.
*/
inline SmartVertexHandle new_vertex(const Point& _p)
inline SmartVertexHandle new_vertex(const Point _p)
{
VertexHandle vh(Kernel::new_vertex());
this->set_point(vh, _p);
@@ -226,9 +223,9 @@ public:
* new_vertex(const Point &) saves reallocation and reinitialization of
* property memory.
*
* \sa new_vertex(const Point &)
* \sa new_vertex(const Point )
*/
inline SmartVertexHandle new_vertex_dirty(const Point& _p)
inline SmartVertexHandle new_vertex_dirty(const Point _p)
{
VertexHandle vh(Kernel::new_vertex_dirty());
this->set_point(vh, _p);
@@ -237,16 +234,12 @@ public:
/** Alias for new_vertex(const Point&).
*
* \attention Be careful to not use a reference to a point in the mesh itself here.
* as a resize of the underlying vector might invalidate this reference
* and cause a segfault.
*
*/
inline SmartVertexHandle add_vertex(const Point& _p)
inline SmartVertexHandle add_vertex(const Point _p)
{ return new_vertex(_p); }
/// Alias for new_vertex_dirty().
inline SmartVertexHandle add_vertex_dirty(const Point& _p)
inline SmartVertexHandle add_vertex_dirty(const Point _p)
{ return make_smart(new_vertex_dirty(_p), this); }
// --- normal vectors ---